search

Johni0702 / BetterPortals

A Minecraft Mod which adds see-through portals usable without any loading screen
GNU General Public License v3.0
107 stars 15 forks source link

Add custom pathing for mobs, Potentially add block placing too? #63

Open sm9cc opened 5 years ago

sm9cc commented 5 years ago

So first off, this mod is mindblowing, the work you have done so far is amazing.

I had a couple of ideas (Should be possible I think)

Thanks!

Johni0702 commented 5 years ago

It may be possibly to modify some of the AI tasks to work with portals but it may be quite tricky to do. And I might also be missing some important detail because I'm not at all familiar with it and only just now had a look. I've keeping this issue open for that feature.

For placing blocks in portals, there's #44 but I've got really no good idea to solve it (especially no generic way). The best thing I can think of is making portal blocks tile entities (possibly on demand) and then more or less re-implementing whichever thing you want to be able to work between the two dimensions.

For rail transport there's also the issue that entities can't use portals when they're riding/being ridden, neither in vanilla MC nor (atm) with BP.

sm9cc commented 5 years ago

Understandably tricky so no rush :)

Thanks.

DarianLStephens commented 5 years ago

How about just placing blocks on the opposite side of the portal? Say you want to place a block in the Nether while in the Overworld, no connection between them. That would be good. At the very least, it'd be nice to get rid of the bounding box on the portal blocks.

sm9cc commented 5 years ago

How about just placing blocks on the opposite side of the portal? Say you want to place a block in the Nether while in the Overworld, no connection between them. That would be good.

That sounds a lot easier.

Johni0702 commented 5 years ago

How about just placing blocks on the opposite side of the portal? Say you want to place a block in the Nether while in the Overworld, no connection between them. That would be good.

https://github.com/Johni0702/BetterPortals/issues/10 Gets surprisingly (or unsurprisingly if you're used to portals) tricky to implement though once you consider that stuff which gets placed / broken can depend on the acting entity's position (e.g. piston placement) and potentially other properties.

At the very least, it'd be nice to get rid of the bounding box on the portal blocks.

Not sure what you mean. There is no bounding box on the portal blocks otherwise you'd see their outlines when you look at them (well, they have one but it's of zero size, so they effectively have none).

Also, I'd prefer to keep this issue on custom AI pathing only. Please open a separate issue for other things.

DarianLStephens commented 5 years ago

Right, I've just discovered that the blocks don't have a bounding box; it's blocks directly against the back of the portal whose bounding box is poking through the screen.

Johni0702 commented 5 years ago

Right, I've just discovered that the blocks don't have a bounding box; it's blocks directly against the back of the portal whose bounding box is poking through the screen.

Good catch. MC draws them with a tiny (but non-zero) offset from the block which is why they show through. Fixing #10 requires fixing the code that checks which block you're looking at, which will also then fix this rendering issue.