iChun Portal Gun compatibility

[dequbed]

Somewhat expectedly, using iChuns Portal Gun mod with this one breaks rendering in cool and wacky ways:

Since fixing this would probably require deep integration with the Portal Gun mod whose source isn't available at the moment I don't expect this issue to have a high priority or be fixed at all, I just like the way it looks.

This screenshot was taken using betterportals-0.1.4 and PortalGun-1.12.2-7.1.0

[C0rn3j]

@Johni0702 Could you please link to this issue from the CF description?

I thought the game outright crashes with portalguns in it and was about to disable the mod altogether.

[Johni0702]

Turns out most of the portal code is actually in iChunUtil (which is LGPL3 and as such has source available) (called WorldPortals in its code, so I'm going to abbreviate those portals with iChunWP from now on).

Above two commits fix the weird rendering issues.

The first commit fixes the incorrect camera orientation with any mod which renders the same world twice if BP is installed (so this might also benefit GLASS).

Reliably rendering BP portals inside iChunWP is inherently impossible due the difference in how iChunWP and BP portals work. Therefore, the second commit explicitly disables BP portals in iChunWP.

iChunWP do not render correctly inside of BP portals. They should in theory be able to work but I can't be bothered to find the problem right now (which is why I'm keeping this issue open).

This screenshot sums up the current state as of BP 0.2.4:

[Traincrafter111]

Hey man I have BP 0.2.7 and PortalGun7.1.0 but I have rendering problems (the problems happens inside the portal of portalgun)

[Johni0702]

@Traincrafter111 Please open a separate issue and explain in more detail what issues you're having. Also, if it happens only inside of the portalgun portal, then it might just be an issue with portalgun itself, it does have quite a few bugs (like chunks and entities not rendering depending on where you're standing).

[metakot]

Writing here to help all who has a decent modpack with BP and Portal Gun installed. Actually this is not a big issue, but I believe I have to mention it here. Going to Nether and back lags in a moment of teleportation (with BP 0.3.7.1 and PG 7.1.0 only). There is the screenshot where I sneaking back and forth between nether and overworld, no PG portals here, just one obsidian. Rendering distance is at 10 chunks.

Without Portal Gun the teleporation runs very smooth, so I think its the PG code which interferes the cross-dimensional teleportaion. Better Portals just made it more demonstrative.