search

Johni0702 / mumble-web

An HTML5 Mumble client
682 stars 151 forks source link

Improvements in channels #128

Closed joker-x closed 3 years ago

joker-x commented 4 years ago

Peek 17-09-2020 22-15

Johni0702 commented 3 years ago

I've cherry-picked the startMute/Deaf options into master: 78161b3

The implementation of the expanding feature seems to be in a very strange place where I would expect it to be triggered whenever the user count of a channel changes (i.e. anyone moves around), certainly not what you'd want. Feel free to open a new PR if you're still interested in this feature (it sounds like a good feature) or if I'm misunderstanding it.

joker-x commented 3 years ago

I don't really understand what the problem is. The behavior is the same as in the desktop client: all channels with users are expanded (and their parents as well).

Do you suggest that the only channel that expands is where the user is?

joker-x commented 3 years ago

This month i will have time to expend in personal projects. If you could explain the behavior desired for this feature and where it should be triggered, I will like to try another pull request.