search

Johni0702 / mumble-web

An HTML5 Mumble client
675 stars 151 forks source link

Covert &username= to something murmur accepts #96

Open mvgorcum opened 4 years ago

mvgorcum commented 4 years ago

If you input an emoji or a name with spaces there you have to manually change your name to something without special characters. That's a good solution, but it may be desirable to just drop any special characters as a first attempt to make joining a matrix-widget a bit more smooth.

toennito commented 4 years ago

Please do no such a thing! I think input formatting should be done by the calling application Matrix in this case. I configured my murmur server to accept many special characters and spaces in usernames and that is a feature of mumble I would expect to work with mumble-web as client... The config option is "username". Here is the guide: https://wiki.mumble.info/wiki/Murmurguide#Configuring_ini_File

Johni0702 commented 4 years ago

Teonnito is right in that you can fairly easily configure the mumble server to accept almost any user name. I also tend to agree that mumble-web should not silently be modifying user names. More importantly however, I don't think it can even modify the names because it cannot know which names are allowed by the server nor how the current one must be changed to no longer be rejected.

Afaict the only sensible way to implement this would be to require the admin to specify in mumble-web's config which characters to remove. That only really makes sense if there's a reason for the admin to not just configure the mumble server to allow those characters to be used (which generally seems like the more desirable solution to me). And at that point, one could even argue that this should be a feature in the mumble server rather than just one of the clients.