Johnmacrocraft / Newspaper

Add newspapers to your server!
https://github.com/Johnmacrocraft/Newspaper
GNU Lesser General Public License v3.0
9 stars 3 forks source link

InternalServerError on Manage Newspapers button #9

Closed KadTheHunter closed 5 years ago

KadTheHunter commented 5 years ago

Issue description

Manage Newspapers button causes an internal server error

Steps to reproduce the issue

  1. Do /newspapers
  2. Select "Manage Newspapers"

OS and versions

Crashdump, backtrace or other files

2019-05-07 [23:10:18] [Server thread/CRITICAL]: ErrorException: "Undefined variable: options" (EXCEPTION) in "plugins/Newspaper.phar/src/Johnmacrocraft/Newspaper/forms/ManageForm" at line 37
2019-05-07 [23:10:18] [Server thread/DEBUG]: #0 plugins/Newspaper.phar/src/Johnmacrocraft/Newspaper/forms/ManageForm(37): pocketmine\utils\Utils::errorExceptionHandler(integer 8, string Undefined variable: options, string phar:///home/container/plugins/Newspaper.phar/src/Johnmacrocraft/Newspaper/forms/ManageForm.php, integer 37, array Array())
2019-05-07 [23:10:18] [Server thread/DEBUG]: #1 plugins/Newspaper.phar/src/Johnmacrocraft/Newspaper/forms/MainForm(49): Johnmacrocraft\Newspaper\forms\ManageForm->__construct(string vespersoup48737, pocketmine\lang\BaseLang object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #2 plugins/Newspaper.phar/src/Johnmacrocraft/Newspaper/libs/dktapps/pmforms/MenuForm(77): Johnmacrocraft\Newspaper\forms\MainForm->Johnmacrocraft\Newspaper\forms\{closure}(pocketmine\Player object, integer 2)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #3 src/pocketmine/Player(3451): Johnmacrocraft\Newspaper\libs\dktapps\pmforms\MenuForm->handleResponse(pocketmine\Player object, integer 2)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #4 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(259): pocketmine\Player->onFormSubmit(integer 6, integer 2)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #5 src/pocketmine/network/mcpe/protocol/ModalFormResponsePacket(49): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleModalFormResponse(pocketmine\network\mcpe\protocol\ModalFormResponsePacket object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(109): pocketmine\network\mcpe\protocol\ModalFormResponsePacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/BatchPacket(123): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\ModalFormResponsePacket object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(109): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #9 src/pocketmine/Player(3115): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/RakLibInterface(170): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #11 vendor/pocketmine/raklib/src/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 142.93.247.245 44513, raklib\protocol\EncapsulatedPacket object, integer 0)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(110): raklib\server\ServerHandler->handlePacket()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #13 src/pocketmine/network/mcpe/RakLibInterface(100): pocketmine\network\mcpe\RakLibInterface->process()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #14 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #15 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #16 src/pocketmine/Server(2338): pocketmine\snooze\SleeperHandler->sleepUntil(double 1557270618.1513)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #17 src/pocketmine/Server(2196): pocketmine\Server->tickProcessor()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #18 src/pocketmine/Server(1775): pocketmine\Server->start()
2019-05-07 [23:10:18] [Server thread/DEBUG]: #19 src/pocketmine/PocketMine(258): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /home/container/, string /home/container/plugins/)
2019-05-07 [23:10:18] [Server thread/DEBUG]: #20 (1): require(string phar:///home/container/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
Johnmacrocraft commented 5 years ago

Next time, please use the code block for the backtrace.

This issue was already fixed on d602de180c2ca46ffdb676d9f22357684d59bb1c, but I haven't made a new release on Poggit yet. You can download the latest development version if you want, though.