JohnnyGoodrich / movie-frontend

2 stars 1 forks source link

Glow #25

Open JohnnyGoodrich opened 1 year ago

JohnnyGoodrich commented 1 year ago

Even though several people working on the same project can cause organizational challenges, having the benefit of all members' knowledge helped us solve many problems that would arise throughout the app making process. When one of us would run into an issue/blocker, we could leverage the knowledge and skills of our teammates.

getting the average function to work (only on the localhost) was a collaborative effort:

    let averageRating = 0
    async function average() {
        const array = []
        let sum = 0
        try {
            for (let i = 0; i < reviews.length; i++) {
                array.push(reviews[i].rating)
                sum += array[i]
                averageRating = sum / array.length
            }
        } catch (err) {
            console.log(err)
        }
    }
    average()
krabecb commented 1 year ago

1 - does not meet expectations , 2 satisfactory, 3 exceeds expectations.

3: User Centered / Feature Rich 3: Has three key features of original app (and may enhance /put a spin on the current behavior or appearance) 3: Database Complexity 3: DB has two models with some association (1:M is default) with full CRUD between 2 or more models. 3: API Architecture 3: RESTful Routes - Design the CRUD routes using RESTful convention. 3: API Integrations 3: React frontend consumes Express backend 3: Version Control: 3: Git 50+ commits between FE / BE repos. 3: Code Quality: 3: Proper indentation, variable naming conventions demonstrated in class are present throughout code. Where code is complex or idiosyncratic comments are provided to describe behavior 3: Clean Code: 3: Well organized application directories, very little repeated code, non-descriptive comments are removed 3: Visual Design: 3: Basic styling is present and provides an easy to use, visually appealing user experience. Custom CSS and layout tools provide a non-buggy desktop experience. 3: Deployment: 3: Both frontend and backend applications are deployed to production - Netlify / Heroku services are used and work appropriately. 3: Documentation: A project readme is provided is included in one of the two repos. Planning materials are available and linked to. 3: Documentation materials cover topics included in project notion.

60 pts - Exceptional

Excellent work on this project everyone! This looks amazing! Great addition to your portfolio! 🚀