search

JohnnyHendriks / TestAdapter_Catch2

Visual Studio Test Adapter for Catch2
MIT License
104 stars 29 forks source link

Fix ExecutionMode documentation #56

Closed Shadorc closed 2 years ago

Shadorc commented 2 years ago

The regex used to match this option are:

static readonly Regex _rgxExMode_Combine = new Regex(@"^(?i:combine)(?i: ?testcases)?$", RegexOptions.Singleline);
static readonly Regex _rgxExMode_Single = new Regex(@"^(?i:single)(?i: ?testcases)?$", RegexOptions.Singleline);
JohnnyHendriks commented 2 years ago

Thank you, for providing a pull request. However, as I was editing the relevant file anyway for the new release I saved myself some hassle and manually made the change as part of those changes.

Shadorc commented 2 years ago

Hello @JohnnyHendriks , after looking at your changes, you didn't make all the fixes, there are still occurrences of "Combined" in the documentation. https://github.com/JohnnyHendriks/TestAdapter_Catch2/blob/main/Docs/Settings.md#combinedtimeout: when <ExecutionMode> is set to Combined https://github.com/JohnnyHendriks/TestAdapter_Catch2/blob/main/Docs/Settings.md#executionmodeforcesingletagrgx: when the Combined execution mode is set.

JohnnyHendriks commented 2 years ago

Thanks for keeping me sharp. Did a text search this time, and found some additional places that needed fixing. Fixed now.