search

JohnnyHendriks / TestAdapter_Catch2

Visual Studio Test Adapter for Catch2
MIT License
104 stars 29 forks source link

DLL Runner #65

Open OskiKervinen-MF opened 1 year ago

OskiKervinen-MF commented 1 year ago

I feel like I wrote this message already a while back, but I can't find it anywhere, so maybe I forgot to send it? Sorry for the redundancy if I just didn't find the previous instance.

When making #63 I tried to be generic in hopes of getting the change upstream. In the discussion there, it sounds like you have your own vision of supporting the DLL use case, and won't be accepting my approach. Instead, you recommended using a private fork until the upstream supports this case. With that in view, I implemented the functionality in a less generic way, more precisely suited for our needs. This MR contains that implementation. I don't necessarily expect you to merge this, but thought it may be useful as a reference.

The idea here is to explicitly support using an executable wrapper to run the tests when the original source is a DLL file.

Includes the changes from #64 because I'll redistribute the fork via NuGet.

JohnnyHendriks commented 1 year ago

Thank you for your effort. This is useful. Didn't think of making it available as a NuGet package as I associate that with the C# world, not the C++ world. Something for me to look into.