search

JohnnyMorganz / StyLua

An opinionated Lua code formatter
Mozilla Public License 2.0
1.59k stars 71 forks source link

VSCode extension does not honor .editorconfig path overrides #864

Open zarillion opened 5 months ago

zarillion commented 5 months ago

We're looking at moving from lua-format to StyLua for our project and have encountered a hurdle. Our project contains a number of localization files where we like to remove the column limit to prevent wrapping. This leaves it up to the translators how they want to format their translations.

I did not see a way to apply path-specific settings using .stylua.toml, so we have this .editorconfig file:

[*.lua]
max_line_length = 120

[**/localization/**.lua]
max_line_length = 1000

When running stylua directly, ec4rs picks up this override and the configuration is honored. However, when formatted on save in VSCode using the extension, the max_line_length override is not honored.

Is there a way to set up the .editorconfig files such that the editor picks up this override as well? I assume the editor may just be passing the file name and contents to StyLua, so the path-specific section is not picked up on save.

zarillion commented 2 months ago

Just wanted to post an update! With the new WoW expansion we've released a new plugin and we're still very much interested in this feature for swapping formatters!