JohnnyMorganz / luau-lsp

Language Server Implementation for Luau
MIT License
205 stars 52 forks source link

Add support for the Zed editor #597

Open filiptibell opened 3 months ago

filiptibell commented 3 months ago

It would be great if luau-lsp supported the Zed editor which just recently got extensions support. I think we could have a similar setup to the Biome LSP extension.

Some things to consider:

Malakai0 commented 3 months ago

All of the tree-sitter implementations of Luau grammar have had issues from my experience. It's probable that if this was attempted, making tree-sitter grammar for Luau from scratch would be necessary. I've had to do heavy modification to existing grammars in order to get my neovim configuration working fine.

JohnnyMorganz commented 3 months ago

I made one a while ago but it is not up to date nor have i checked its correct. Might be reasonable to build off though: https://github.com/JohnnyMorganz/tree-sitter-luau

The custom requests are not blockers, more just nice to haves

lopi-py commented 3 months ago

There is this one used in neovim: https://github.com/tree-sitter-grammars/tree-sitter-luau/ I have no problems using it in neovim. Zed is using the grammars from the same github org (tree-sitter-grammars)

techs-sus commented 5 days ago

Many things have changed since the last update on this, but Zed added an extension API (or updated it?) to allow for LSP support. Teapo has graciously created an extension which perfectly works on Zed which adds LSP support, and configuration support. This extension has already gotten merged into the extension registry, and it is being maintained (see https://github.com/zed-industries/extensions/pull/1058).

Extension (created by teapo): https://github.com/4teapo/zed-luau