Trying to use Luau LSP when debugging another extension causes it to try to run unknown.exe

JohnnyMorganz / luau-lsp

Language Server Implementation for Luau

MIT License

203 stars 51 forks source link

Trying to use Luau LSP when debugging another extension causes it to try to run unknown.exe #644

Open LordOfSpelunky opened 1 month ago

LordOfSpelunky commented 1 month ago

https://github.com/JohnnyMorganz/luau-lsp/blob/6a998a04d1fc5fcf4df0dd7b0923f165b687607e/editors/code/src/extension.ts#L174

I'm working on my own VS Code extension and trying to do so appears to make Luau LSP try to use this unknown.exe.

LordOfSpelunky commented 1 month ago

It looks like this is partially a weird behavior from vscode-language-client 🤷‍♀️

JohnnyMorganz commented 1 month ago

Maybe we can just point to the normal binary if SERVER_PATH doesn't exist. Not sure why I chose unknown.exe other than making sure we don't silently pick the wrong one when debugging