search

JohnnyMorganz / luau-lsp

Language Server Implementation for Luau
MIT License
198 stars 48 forks source link

Extension configuration for sourcemap name #661

Open TRHeliad opened 1 week ago

TRHeliad commented 1 week ago

It would be very useful if there was an option such as luau-lsp.sourcemap.mapFile that would allow you to change the name of the sourcemap file that luau lsp looks for.

I am setting up the structure for a new rojo managed project which involves multiple places and would like to enable intellisense for multiple places at once. The problem I have is that luau lsp only looks for a file specifically named sourcemap.json in the root directory of the workspace. I would like to configure a vscode workspace which changes the name of the sourcemap file that luau lsp looks for using a configuration. I would then use individual vscode windows with workspaces corresponding to places which are configured for specific sourcemap files.

TRHeliad commented 6 days ago

Would it be better to have the property allow you to select a prefix for the file or just define the entire name? I was implementing this earlier and noticed that if you define the entire name it would require updating the file watchers.

JohnnyMorganz commented 6 days ago

The file watcher will need to be modified regardless of what we choose, so I think defining the entire name is good.

We probably want to move the file watcher to the "setupWithConfiguration" inside of RobloxPlatform as well, since it is a roblox-specific thing, and we have access to the configured name at that point. Maybe we should also de-register the file watcher if the sourcemap setting was disabled