JohnnyMorganz / luau-lsp

Language Server Implementation for Luau
MIT License
218 stars 57 forks source link

Separate auto-import ignores from `luau-lsp.ignoreGlobs` #686

Closed lolmanurfunny closed 1 month ago

lolmanurfunny commented 1 month ago

I was trying to figure out why I wasn't able to auto-import my packages... eventually I realized that the **/Packages/** I had in my ignore globs was to blame.

The luau-lsp.ignoreGlobs setting currently influences auto-imports yikes, it should only influence diagnostics, as advertised (see image). Auto-imports should be given their own ignore globs. You shouldn't need to compute diagnostics for a file just to get it to show up in auto-imports.

image

JohnnyMorganz commented 1 month ago

Agreed that the description doesn't make sense. However it is important we have an ignore in the first place, since we wouldn't want to auto import anything in _Index

Yes I think we should have a separate setting for auto import ignores