JohnnyOpcode / degrafa

Automatically exported from code.google.com/p/degrafa
1 stars 0 forks source link

Review for beta3 or release version 1- method not implemented in DegrafaCollection #60

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
From Groups/zyrconium:
Hello!

Perhaps you could update the code for DegrafaCollection to implement
functionality for _setItemIndex function, please?

It now looks like this:

protected function _setItemIndex(value:*,newIndex:Number):Boolean{
     return true;

}

But maybe it could look like this:

protected function _setItemIndex(value:*,newIndex:Number):Boolean{
     var spliced:Array = this.items.splice(this.items.indexOf(value),
1);
     this.items.splice(newIndex, 0, spliced[0]);
     return true;

}

Maybe you can make it faster/better. But make it do something :) 

Original issue reported on code.google.com by greg.d...@gmail.com on 22 Oct 2008 at 5:57

GoogleCodeExporter commented 8 years ago
Fixed for Beta3 see rev http://code.google.com/p/degrafa/source/detail?r=388

Original comment by Flexible...@gmail.com on 12 Nov 2008 at 8:39