search

JohnsonGao / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

Figure out if we need an |IsValidDocument| function #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As seen in https://codereview.chromium.org/441763002/, lines 274 – 285 of 
fpdfsdk/src/fsdk_actionhandler.cpp either can be simplified, or we need to 
reinstate (?) / create an |IsValidDocument| function.

Original issue reported on code.google.com by pal...@chromium.org on 4 Aug 2014 at 10:51

GoogleCodeExporter commented 9 years ago 
I will check and get back to this one.

Original comment by bo...@foxitsoftware.com on 4 Aug 2014 at 10:53

GoogleCodeExporter commented 9 years ago 
Hi Chris, we can get rid of |IsValidDocument| and use while(1) or just get rid 
of while(1). The function was only a tentative try code.

Original comment by bo...@foxitsoftware.com on 6 Aug 2014 at 6:46

GoogleCodeExporter commented 9 years ago 
OK I'll take care of it now. Thanks!

Original comment by pal...@chromium.org on 6 Aug 2014 at 8:28

GoogleCodeExporter commented 9 years ago 
https://codereview.chromium.org/451483003/

Original comment by pal...@chromium.org on 6 Aug 2014 at 8:38

GoogleCodeExporter commented 9 years ago

Original comment by pal...@chromium.org on 6 Aug 2014 at 10:35