search

JohnsonGao / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

fpdf_ext.cpp still calling FPDF_UnSupportError(FPDF_UNSP_DOC_XFAFORM); on XFA branch. #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This results in a needless warning from pdfium_test against XFA cases.

Original issue reported on code.google.com by tsepez@chromium.org on 18 Nov 2014 at 10:50

GoogleCodeExporter commented 9 years ago 
at or around fpdf_ext.cpp:215
   // XFA Forms                                                                                                                                                
    CPDF_InterForm * pInterForm = FX_NEW CPDF_InterForm(pDoc,FALSE);
    if (pInterForm)
    {
        if(pInterForm->HasXFAForm())
        {
            FPDF_UnSupportError(FPDF_UNSP_DOC_XFAFORM);
        }
        delete pInterForm;
    }
}

Bo, can we safely remove this code?

Original comment by tsepez@chromium.org on 18 Nov 2014 at 10:53

GoogleCodeExporter commented 9 years ago 
Yes, this should be removed in XFA branch. Let me send a patch on that.

Original comment by bo...@foxitsoftware.com on 19 Nov 2014 at 12:30

GoogleCodeExporter commented 9 years ago 
CL at https://codereview.chromium.org/818543002/

Original comment by tsepez@chromium.org on 18 Dec 2014 at 11:13

GoogleCodeExporter commented 9 years ago 
https://pdfium.googlesource.com/pdfium/+/293b95f26ee3b561db09ecec88406583e7d566f
6

Original comment by tsepez@chromium.org on 18 Dec 2014 at 11:14

GoogleCodeExporter commented 9 years ago

Original comment by tsepez@chromium.org on 18 Dec 2014 at 11:14