search

JohnsonHsieh / iNEXT

R package for interpolation and extrapolation
https://JohnsonHsieh.github.com/iNEXT
57 stars 26 forks source link

New argument to `estimateD` to warn about duplicates and optionally remove without error #71

Closed mikeroswell closed 2 years ago

mikeroswell commented 2 years ago

This (like another PR from KaiHsiangHu) was an attempt to resolve #67. I added a warning about duplicates and an removeDups argument to estimateD that I think, when TRUE, removes duplicates without throwing an error due to name mismatches. The documentation didn't exactly update for me with devtools::document(), and this PR wasn't passing R CMD check on my machine, but I think that will be very quick for the maintainers.

JohnsonHsieh commented 2 years ago

ref to https://github.com/JohnsonHsieh/iNEXT/pull/68

mikeroswell commented 2 years ago

Closing this PR as it looks like the duplicate removal was deemed unnecessary, merging #68 solved my issue and way more simply.