search

JohnstonCode / svn-scm

SVN support for VS Code
MIT License
208 stars 84 forks source link

fix: bind repoWatch to RepositoryFilesWatcher object #1591

Closed FractalBoy closed 1 year ago

FractalBoy commented 1 year ago

Currently, when files are changed, there is an exception that breaks the SVN extension.

2022-12-20 17:21:44.105 [error] TypeError: Cannot read properties of undefined (reading 'fire')
    at /home/mreisner/.vscode-server/extensions/johnstoncode.svn-scm-2.15.5/out/extension.js:2:278235

This pull request binds the call to this.repoWatch to the RepositoryFilesWatcher object so that this exception isn't triggered.

JohnstonCode commented 1 year ago

Thanks for the PR!

JohnstonCode commented 1 year ago

:tada: This PR is included in version 2.15.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

FractalBoy commented 1 year ago

Hey @JohnstonCode - I don't see the new version on Visual Studio Marketplace. Does it take a while to show up?

JohnstonCode commented 1 year ago

I'll have a look not usually its a couple of minutes

JohnstonCode commented 1 year ago

It seems Microsoft change the rules around allowed badges in the readme. I have fixed this and 2.15.7 is now available