JohnstonCode / svn-scm

SVN support for VS Code
MIT License
208 stars 84 forks source link

Viewing HEAD information shows all information has changed and kills PowerShell extension #170

Closed mpearon closed 6 years ago

mpearon commented 6 years ago

Issue

After a versioned file is modified (in this case a .psm1) and saved, the plugin detects changes. I then switch to Source Control in the Activity Bar. If I just submit the file, all is well - but if I click the file to view the HEAD info, it reports back that the entire file was changed, then after a moment, the PowerShell session terminates.

Steps to Reproduce

Sample

headcrash

edgardmessias commented 6 years ago

@mpearon , you can send the svn log?

mpearon commented 6 years ago

@edgardmessias - Sorry for the delay - back to work after a long weekend. I hope this is what you're after:

Using svn 1.9.7 (r1800392) from C:\Program Files\TortoiseSVN\bin\svn.exe
[DIT]$ svn info --xml
[DIT]$ svn stat --xml --no-ignore
[DIT]$ svn log -r BASE:HEAD -q --xml
[DIT]$ svn info --xml
[DIT]$ svn stat --xml --no-ignore
[DIT]$ svn stat --xml --no-ignore
[DIT]$ svn info --xml

That is when it is in the state you see in the screenshot above. Something to note, though: the PowerShell extension didn't bomb out this time.

edgardmessias commented 6 years ago

@mpearon, I can't reproduce here @JohnstonCode, you can reproduce?

JohnstonCode commented 6 years ago

@edgardmessias unable to reproduce here

mpearon commented 6 years ago

Is there anything more I can provide you guys for troubleshooting? It's consistent on my end. In the meantime, I'll verify that I can reproduce the issue on another machine with the same environment.

JohnstonCode commented 6 years ago

Yeah if you can try on another machine in the same environment that will help.

edgardmessias commented 6 years ago

@mpearon, try disable all plugins and run. Maybe it's another plugin the problem

mpearon commented 6 years ago

@edgardmessias and @JohnstonCode - I have switched to a new machine, synced my settings, then disabled all extensions. Unfortunately, this was all to no avail.

Here are a few screenshots Disabled settings: image

Head from vsCode: image

Head from Tortoise: image

JohnstonCode commented 6 years ago

@mpearon Thanks for going through all that trouble.

I'll try again to replicate.

JohnstonCode commented 6 years ago

@mpearon can you screenshot the output window when you are getting HEAD from the screenshot above?

mpearon commented 6 years ago

@JohnstonCode - It's no problem at all! I greatly appreciate you taking the time to troubleshoot! :)

If this is what you're after (hopefully I didn't misunderstand), there isn't much to see: image

Edit: This is the same with and without other extensions enabled.

JohnstonCode commented 6 years ago

Can you screenshot the debug console as well please?

edgardmessias commented 6 years ago

Not running the command: svn cat ....

edgardmessias commented 6 years ago

@mpearon, please, run the commands: svn info <filename> and svn status --no-ignore <filename>

mpearon commented 6 years ago

@JohnstonCode and @edgardmessias - Here is the output you requested.

svn info:

PS Microsoft.PowerShell.Core\FileSystem::\\SERVERNAME\DIT> svn info \\SERVERNAME\DIT\ScriptRepository\Modules\Modules\ServiceDesk\ServiceNow\CTS-ServiceNow.psm1
Path: ScriptRepository\Modules\Modules\ServiceDesk\ServiceNow\CTS-ServiceNow.psm1
Name: CTS-ServiceNow.psm1
Working Copy Root Path: \SERVERNAME\DIT
URL: https://SERVERNAME/svn/common/DIT/ScriptRepository/Modules/Modules/ServiceDesk/ServiceNow/CTS-ServiceNow.psm1
Relative URL: ^/DIT/ScriptRepository/Modules/Modules/ServiceDesk/ServiceNow/CTS-ServiceNow.psm1
Repository Root: https://SERVERNAME/svn/common
Repository UUID: 4bc623e6-e24c-4786-a4d0-aa7ffe565fda
Revision: 104
Node Kind: file
Schedule: normal
Last Changed Author: matthew_pearon
Last Changed Rev: 104
Last Changed Date: 2018-02-26 09:24:17 -0600 (Mon, 26 Feb 2018)
Text Last Updated: 2018-02-26 09:19:18 -0600 (Mon, 26 Feb 2018)
Checksum: 5f9354d73c311275ed80465f755592f2098bb4e3

svn status --no-ignore: M \\SERVERNAME\DIT\ScriptRepository\Modules\Modules\ServiceDesk\ServiceNow\CTS-ServiceNow.psm1

edgardmessias commented 6 years ago

lOl, UNC path, I can now do test

mpearon commented 6 years ago

I'm sorry! I didn't think to mention that it was a UNC path. After a few years in this field, you would think that my default posture would be to offer all details - even the ones I wouldn't think to be related/important.

edgardmessias commented 6 years ago

@mpearon, test this: https://ci.appveyor.com/api/buildjobs/5wgi9unbr9liw22p/artifacts/svn-scm.vsix

Instalation: https://code.visualstudio.com/docs/editor/extension-gallery#_install-from-a-vsix

mpearon commented 6 years ago

@edgardmessias - I was able to add the VSIX. For whatever reason, vsCode isn't getting the hint that it is acting as an SC provider. image

Proof that it is installed: image

edgardmessias commented 6 years ago

Sorry, I find a bug in package.

Try this: svn-scm.zip

mpearon commented 6 years ago

@edgardmessias - The installation procedure requested a couple of reloads that time, but vsCode is still not seeing the SC provider for some reason. Any logs I can provide you?

Edit - I tried this again, and it worked. Testing the Head issue now.

mpearon commented 6 years ago

@edgardmessias - Unfortunately, it looks the same: image

This was the same with and without other extensions enabled.

edgardmessias commented 6 years ago

Disable the auto update and reinstall

mpearon commented 6 years ago

Oh, I didn't think about the auto-update getting it. Whatever you did there fixed the issue! :) image

edgardmessias commented 6 years ago

Good, now wait the new release.

mpearon commented 6 years ago

Awesome! Thank you for all of your assistance and troubleshooting! :) Thank you too, @JohnstonCode!