search

JohnvandeVrugt / toonapilib4domoticz

A simple toonapilib based python plugin for domoticz
MIT License
7 stars 6 forks source link

Prevent unnecessary burner state updates #10

Closed arjanwaard closed 5 years ago

JohnvandeVrugt commented 5 years ago

Hi Arjan,

your commit seems to be valid, however, I'm currenty working on a complete rework of the plugin. In that code, if I'm not mistaken, each device checks its own previous value before updating domoticz. I expect to release this rework in the coming days...

arjanwaard commented 5 years ago

No problem, but be aware the burner state has 3 on states and only 1 off state. Thanks for doing the work on the plugin by the way, much appreciated !

On Wed, Mar 13, 2019 at 2:13 PM John van de Vrugt notifications@github.com wrote:

Hi Arjan,

your commit seems to be valid, however, I'm currenty working on a complete rework of the plugin. In that code, if I'm not mistaken, each device checks its own previous value before updating domoticz. I expect to release this rework in the coming days...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JohnvandeVrugt/toonapilib4domoticz/pull/10#issuecomment-472416233, or mute the thread https://github.com/notifications/unsubscribe-auth/AI0oR78mhcPJDhciepzTbJJPSBzywig3ks5vWPmOgaJpZM4bpoB9 .

darkrain-nl commented 5 years ago

Hi Arjan,

your commit seems to be valid, however, I'm currenty working on a complete rework of the plugin. In that code, if I'm not mistaken, each device checks its own previous value before updating domoticz. I expect to release this rework in the coming days...

Hi @JohnvandeVrugt ,

If you need someone to test the rewritten code other then yourself, just let me know. Or just create a beta branch or something like that.

I'm happy to help and don't mind to do some bugfixing (as far as I can, still not a Python guru).

arjanwaard commented 5 years ago

Closed waiting for the refactoring