Johnw11 / arducopter

Automatically exported from code.google.com/p/arducopter
0 stars 0 forks source link

NMEA rounding error #494

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

Please see the description  here
http://www.diydrones.com/forum/topics/nmea-gps-warning

It's the faulty conversion of coordinates from NMEA to internal format.

What version of the product are you using? On what operating system?

Arducoper 2.7.3 on APM2.

Fix is also described in the post:

One line has to be changed in
 uint32_t AP_GPS_NMEA::_parse_degrees() method:

>     int32_t frac_min = 0;

---
<     uint16_t frac_min = 0;

Apparently uint16 is too short for this operation which leads to rounding 
errors. I checked the version with this fix, it works properly.

Original issue reported on code.google.com by roundfol...@gmail.com on 1 Oct 2012 at 10:20

GoogleCodeExporter commented 9 years ago
I can see the type is now uint32 in 2.9 so issue should be fixed

Original comment by Benny.Si...@gmail.com on 19 Jan 2013 at 7:03

GoogleCodeExporter commented 9 years ago
Issue closed. 
If you find this is an error please report it in the new issues list
https://github.com/diydrones/ardupilot/issues?labels=ArduCopter&page=1&state=ope
n

Original comment by Benny.Si...@gmail.com on 19 Jan 2013 at 7:04