search

JohnyDays / react-credit-card

React port of the display part of Card by @jessepollak
MIT License
229 stars 60 forks source link

Wrong css dependency files folder location #18

Open rfviolato opened 7 years ago

rfviolato commented 7 years ago

Hi! First of all, really nice component 👍

I just npm installed it and the two mentioned css dependency files are not located inside build/ folder as stated on README.md, but i could import them anyway because they are located at source/ folder.

I guess that is not correct, because source/ folder contain uncompressed files.

JohnyDays commented 7 years ago

I was trying to find some time to fix this by rewriting the css into inline styles, making it completely componentized. I'll eventually get around to doing this, I just haven't found opportunity for it. I'll just fix the documentation for now, and keep this issue open for sake of remembering it. Thanks @rfviolato

rfviolato commented 7 years ago

Awesome! No problem ;)

ryan-hamblin commented 7 years ago

@JohnyDays Have you looked in to "Aphrodite-CSS"? It's basically the best Inline-styles/react paradigm way to style your components. I would love to help you get this started if you'd like.

JohnyDays commented 7 years ago

I've looked at aphrodite and glamor, and I seem to like glamor's approach more, but Aphrodite does seem more simple and straightforward to distribute for libs

ryan-hamblin commented 7 years ago

@JohnyDays I'll have to look into Glamor this is the first I have heard of it. I do like Aphrodite for those same reasons. Also you can gain specificity preference really easily being that it injects a component specific style sheet per component. This is HUGE in that you're not actually writing inline styles, the styles simply get injected in the "Head" of the document as the component is mounted. That is brilliant IMO. But I'll look into glamor. I do agree though, this component would be +100 if we could non-trivially add our own styles independently. For now, I'm just tweaking the given styles as I've added them to my global stylesheet.