search

JohnyP36 / YT-Nonstop

Extension to let YouTube run nonstop with autoplay, autoconfirm and automatic pressing the loopbutton.
GNU General Public License v2.0
14 stars 1 forks source link

Make extension `fire-and-forget` #24

Closed JohnyP36 closed 8 months ago

JohnyP36 commented 10 months ago

Any additions, changes or removals is at the Authors discretion.
You're free to counterargue (to a certain point) if you disagree with the decision.
To avoid being banned, don't constantly re-open or create new (related) issue reports or pull requests.

Prerequisites

  • [x] I've read the Code of Conduct and the Contributing Guidelines
  • [x] This is more than one or two issue(s)
  • Otherwise open a new issue
  • [x] I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • Your issue may already be reported.
  • [x] I tried to reproduce the issue when...
  • [ ] Other webextensions related to Youtube are disabled
  • [ ] using a new, unmodified browser profile
  • [x] I am running the latest version of the extension

Describe the issue

As it seems that most user install this extension and forget about it (e.g. fire-and-forget) I had to change the code for autoplay to the opposite, so it would turn off YT autoplay on installation. Partly in fulfillment of #21

Browser & Extension version

| Browser name & version | Extension Version | Operating System | | :--- | :---: | ---: | | \`**MS Edge** 119\` | \`_**2.0.9**_\`| \`**Windows 10**, 22H2\` | #### Notes

Reversing the code is possible but not for the position of the slider in the popup: First to the left meant "stopping YT autoplay", now it means "NOT stopping / do nothing".

JohnyP36 commented 10 months ago

@amaurea Given your request at issue #21 I drafted this PR. But I need some feedback from you before I can merge it.

Would you like to answer the following questions?

  1. After you installed the extension/add-on did you open the popup menu to check the settings?
  2. Did you understand what each switch is doing when it's green outlined/filled (in other words: turned on)?
  3. Can you explain to my what you thing the extension is doing when the top switch (stopping YouTube autoplay) is turned off (thus has a red color)?

Thank you in advance.

github-actions[bot] commented 8 months ago

This pull request has been automatically marked as stale because it has not had recent activity.

JohnyP36 commented 8 months ago

@amaurea It has been a while since you opened issue #21 . It would be easier if Firefox supported MV3 the same way as Chromium-based browser, but for now I created this PR which is still waiting for your feedback.

Can you please react to my previous comment? Otherwise this PR will be closed.

github-actions[bot] commented 8 months ago

Sorry @amaurea, you didn't give feedback in time. That's why this PR already got the "stale" label and now get closed.