DRAFT: New feature: set screen timeout in the UI

JohnySeven / TWatchSK

TTGO T-Watch 2020 v1 supporting Signal K features for displaying boat data and controlling devices on board.

MIT License

9 stars 1 forks source link

DRAFT: New feature: set screen timeout in the UI #13

Closed ba58smith closed 3 years ago

ba58smith commented 3 years ago

@JohnySeven - the problem occurs at the end of watch_info.h. See the comment there.

JohnySeven commented 3 years ago

@ba58smith I've fixed the issue, the System_data class didn't have instance created. I've created one in main.cpp and passed it to gui via setup_gui function. Now it works.

I have one proposal, for display related configuration we could create new setup tile "Display" maybe right after "Clock" and add all that is mentioned in #6.

Your opinion on that?

Thanks!

ba58smith commented 3 years ago

Call it Display Settings, maybe? I think that's better than what I did (adding it to Watch Info). I will do that.

ba58smith commented 3 years ago

Wow, I really missed a lot! I thought I was very close because it compiled and ran. I hope you didn't spend too much time on it.

I'll move the code from watch_info.h to a new display_settings.h, and try to implement some more of the features in Issue #6 .

JohnySeven commented 3 years ago

Yes, I like the "Display settings" name. It's ok, I have spend about 30 minutes so no big deal! Great #6 would be great addition!

Thanks Butch!

ba58smith commented 3 years ago

TODO:

~Create a proper icon for "Display settings"~
~Make the screen timeout setting update in real time~

ba58smith commented 3 years ago

This is made obsolete by PR #14 . Closing.