search

JohnySeven / TWatchSK

TTGO T-Watch 2020 v1 supporting Signal K features for displaying boat data and controlling devices on board.
MIT License
9 stars 1 forks source link

Double-tap to switch between LIGHT and DARK themes #43

Closed ba58smith closed 3 years ago

ba58smith commented 3 years ago

It works, but it happens on ALL screens. Any screen with a button (even the "Back" button in the upper left corner) will not look right after a theme change if you do the double-tap on that screen.

We need to either make the double-tap work ONLY on the home screen, or we need a way to update all the buttons and icons on every screen if you double-tap on it to change the theme.

I also made a few unrelated changes - fixed some typos, mostly.

ba58smith commented 3 years ago

I still want to save the theme change that's brought on by a double-tap, so don't merge yet.

ba58smith commented 3 years ago

Everything is working now, but there is one enhancement I can make if you think I should, @JohnySeven. If you're on the Wakeup Settings page, and you disable double-tap wakeup, the double-tap theme switch doesn't work until the next time the watch wakes up. I don't think this is a problem, because if you can see the screen well enough to get to the Wakeup Settings page, and disable the double-tap wakeup, you probably don't need to do the double-tap to switch the screen. You agree?

JohnySeven commented 3 years ago

@ba58smith I'm OK with that, good job! Will test it and merge it! Thanks! :-)

JohnySeven commented 3 years ago

Looking nice, thanks @ba58smith!