search

JohnySeven / TWatchSK

TTGO T-Watch 2020 v1 supporting Signal K features for displaying boat data and controlling devices on board.
MIT License
9 stars 1 forks source link

Include more notifcation states in watch "alarms" #60

Closed ba58smith closed 3 years ago

ba58smith commented 3 years ago

Signal K has these notification states: nominal, normal, alert, warn, alarm, emergency.

Watch recognizes only "alert" and "alarm" for purposes of displaying a message (signalk_socket.cpp line 283).

Shouldn't it also display a message for "warn" and "emergency"?

JohnySeven commented 3 years ago

I agree and if I understand correctly there there states:

And it would be nice to distinguish between warning and critical state. Any ideas here?

ba58smith commented 3 years ago

I think we should do something MORE for an "emergency" - maybe vibrate more, or better yet, play a sound. I don't know if we should do anything less for a "warn" than we do for an "alert" and an "alarm". In all cases, the text of the message appears on the watch, so they can see exactly what's going on.

Maybe we could allow the user to decide if a "warn" will be treated like an "alert" and an "alarm", but I don't think that's necessary. They set these up in something like the Simple Notifications Plugin, so if they don't want to be notified, they just shouldn't set up any "warn" in that plugin. That's what I think, anyway.

ba58smith commented 3 years ago

See PR #67