search

JohnySeven / TWatchSK

TTGO T-Watch 2020 v1 supporting Signal K features for displaying boat data and controlling devices on board.
MIT License
9 stars 1 forks source link

DRAFT: Add "Disable Wifi" button to appropriate messages #61

Closed ba58smith closed 3 years ago

ba58smith commented 3 years ago

First working version. There are some things I don't understand that I want to understand before merging this. But I've tested it, and it seems to work as intended. @JohnySeven , please see some of the questions I've left in the code as comments.

ba58smith commented 3 years ago

@JohnySeven, please let me know how you'd like me to handle this:

Currently, I'm using the new pendingmessages.msg_topic for only one thing: to add the "Disable Wifi" button to the two messages that tell about a wifi problem. I set the msg_topic with new_message.msg_topic = "wifi_problem";, and test it with if (it->msg_topic == "wifi_problem"). I could make a new enum Msg_Topic_t, with one element, "Wifi_Problem", but I don't currently have any other "topics" in mind. Should I leave it as-is, or make an enum?

JohnySeven commented 3 years ago

Looking good - need that stuff, so merging! :-)