Agreements: Status displaying invalid status

[melyndav]

Teamwork task: Agreements: Status displaying invalid status

Description

In production, an agreement is showing with the status as 'invalid' with a 0 rendered in the card.

Important note: motions shouldn't be tested on production in the BetaColony

The motion also didn't complete correctly and nothing is showing under each motion pill.

[CzarekDryl]

I'm not able to replicate this on local env

[rdig]

I think I know of a way to test this.

• Install Voting Reputation
• Create an agreement
• Stake it, so that it shows up in the list
• Deprecate + Uninstall Voting Reputation

That should break the state of the agreement (motions, under the hood), and trigger this invalid state

[CzarekDryl]

@rdig Right after uninstalling extension motion state change to 0 when using useGetMotionStateQuery. Could you please check if it's something with DB?

[arrenv]

This likely requires us handling deprecated and uninstalled extensions in the database.

As it should still show the correct outcome, even if it was created with a previous version of the voting reputation contract.

[rdig]

@arrenv is correct. We cannot currently handle motions from voting rep extensions that have been uninstalled. So for now, the UI needs to account for this case and handle it appropriately

[arrenv]

@AdrianDudko For now, when this situation is detected, can we instead have the UI say "Uninstalled", instead of "Invalid".

[joanna-pagepro]

@arrenv what about displaying this action in the action sidebar? Right now it looks like this:

Motion steps are empty

[melyndav]

@joanna-pagepro I've created a widget similar to the permissions widget to display in the right motion sidebar when an extension is uninstalled. Same widget for mobile.

Mockup: https://www.figma.com/file/5V8pr7iMwXsT9L3VAZsmUt/Colony-v5?type=design&node-id=22857-221890&mode=design&t=05jdMV5HavMx1mkJ-4

Component: https://www.figma.com/file/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?type=design&node-id=3303-19734&mode=design&t=Q8lpfWcaTt0sGPJZ-4

[AdrianDudko]

@melyndav @arrenv

The pull request that @joanna-pagepro worked on has been closed. You can find it at https://github.com/JoinColony/colonyCDapp/pull/2235.

It has been taken over by @davecreaser Comment: https://github.com/JoinColony/colonyCDapp/pull/2235#issuecomment-2239433910 His PR: https://github.com/JoinColony/colonyCDapp/pull/2737

Let's close this one.