Payment fund step is missing in flow due to multiple funding actions - Githubissues

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer

5 stars 14 forks source link

Payment fund step is missing in flow due to multiple funding actions #2399

Open arrenv opened 2 months ago

arrenv commented 2 months ago

Teamwork task: Payment fund step is missing in flow due to multiple funding actions

Steps to reproduce

Create an Advanced payment action.
At the Funding step, fund the payment twice. You should be able to do it by clicking the button twice.
Continue to the next step.
Click back in the funding step.

Expected behaviour

You should see the multiple funding history items.

There are designs for how this should be handled, which has been done as a part of this PR - https://github.com/JoinColony/colonyCDapp/pull/2362

Default state - no transaction selected (Figma Link)

Selected state - on clicking on a transaction (Figma Link)

Actual behaviour

The payment had two or more fund requests, but no history was shown.

CzarekDryl commented 2 months ago

@arrenv I've already implemented this in this PR. This is how it looks:

https://github.com/JoinColony/colonyCDapp/assets/76940796/dfd24f8d-473b-4056-b8a7-ccef57c3bb1a

arrenv commented 2 months ago

@CzarekDryl Thank you. The one you have is for motions, does it support permission based ones as well?