Skeleton loader for Split payment percentage - Githubissues

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer

5 stars 14 forks source link

Skeleton loader for Split payment percentage #2703

Closed arrenv closed 2 days ago

arrenv commented 3 months ago

Teamwork task: Skeleton loader for Split payment percentage

Steps to reproduce

Create a Split payment using the Reputation distribution method.
Add a few recipients.
Create the payment.
Notice the loading state of the recipients table.

This PR https://github.com/JoinColony/colonyCDapp/pull/2396 will likely need to be merged first.

Expected behaviour

There should be a skeleton loader on the percentage field.

Actual behaviour

There is no skeleton loader on the percentage field of the table. Instead it is showing as 0% while loading.

joanna-pagepro commented 3 months ago

@arrenv I think that this is already fixed. Can you check? (feat/advanced-payments-ui)

AdrianDudko commented 2 days ago

@arrenv let me know if that's safe to close this :)

arrenv commented 2 days ago

Yep, closing now.