JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[Bug] The permissions page does not take "inherited" roles into account for users who have specific permissions #2785

Closed iamsamgibbs closed 3 weeks ago

iamsamgibbs commented 3 months ago

Steps to reproduce

  1. Assign payer permissions to a user in a sub domain
  2. Assign admin permissions to the same user in the root domain
  3. Navigate to the permissions page and select the sub domain in the team filter

Expected behaviour

Actual behaviour

Suggestions (optional)

The "inherited" pill could show exactly which permissions have been inherited, in the example above only the Architecture role would be inherited. This is probably more relevant when singular custom permissions have been assigned in the sub-domain and the root domain.

Nortsova commented 3 months ago

It should be solved in scope of - https://github.com/JoinColony/colonyCDapp/pull/2950

Nortsova commented 2 months ago

sorry it was misunderstanding, here is solution - https://github.com/JoinColony/colonyCDapp/pull/2971

rdig commented 2 months ago

@Nortsova did #2971 fix this issue? then please close it

iamsamgibbs commented 2 months ago

Just a note to say this is still an issue on master:

Screenshot 2024-09-10 at 10 48 06
iamsamgibbs commented 2 months ago

@rumzledz has just come across it where the member even has "Admin" permissions in the sub-domain:

permission-issue

rdig commented 1 month ago

@Nortsova this has been active for a almost 3 months now. Please figure out it's status: either close it if it's not relevant, or put in a fix for it

iamsamgibbs commented 1 month ago

@Nortsova Not sure why this issue was closed?

The issue is still occurring as described in the original description on master.

Screenshot 2024-10-14 at 14 40 52

Unrelated, but also appears there has been a regression on the user popover component as the reputation points styling has broken.