JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[New navigation] Action Form cannot dynamically change its contents when you trigger the content change from outside #2824

Open rumzledz opened 3 months ago

rumzledz commented 3 months ago

[!NOTE] This is an issue on Production as well.

Steps to reproduce in the master branch

  1. Go to Dashboard
  2. Click on the Total Funds widget
  3. Click the kebab button for an Asset
  4. Click Make payment using this token
  5. Wait for the Action Form to come up
  6. Click the Create action button on the sidebar
  7. Notice how the Action Form component just bounces and it doesn't show you the "Do you wish to cancel the action creation" modal

Steps to reproduce in the ui/new-navigation-ui branch

  1. On the Colony Page Sidebar, click Create agreement
  2. Verify that the Action Form comes up and the Action type field is set to "Create agreement"

Scenario: Clicking Create agreement again while the action form is active

Scenario: If Payments action group functionality is already implemented

  1. On the Colony Page Sidebar, click Make payment

Result: The Action form just bounces and it's still showing you the Create agreement form Expected result: The Action form should show the Payment action group

Scenario: If Manage colony action group functionality is already implemented

  1. On the Colony Page Sidebar, click Manage colony

Result: The Action form just bounces and it's still showing you the Create agreement form Expected result: The Action form should show the Manage colony action group

rumzledz commented 2 months ago

Might be a good idea to speak with @chmanie just in case he's come across this issue and knows a good way to fix it, since he's worked on a Action Sidebar issue recently

chmanie commented 2 months ago

Pretty sure this would be fixed by my refactor so if it's not urgent, I can take this

rumzledz commented 2 months ago

Pretty sure this would be fixed by my refactor so if it's not urgent, I can take this

Thanks for this @chmanie 🙏 It should be enough to demo that when you click an action on the new sidebar, it should bring up the action form and it should show the correct content 🤞