JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[Prod] Agreements: Mobile users can not exit side panel after creating draft agreement without cancelling action #2933

Open melyndav opened 3 months ago

melyndav commented 3 months ago

Description

On mobile, when users create a draft agreement and safe it, they are forced into the modal confirming the cancellation of the agreement action to be able to exit the side panel.

Correct behaviour:

Once the user has saved the draft action, they should be able to close the side panel without receiving the 'cancel action' confirmation modal. This should only happen on this action once the 'save draft' button has been selected. It should not impact any other action.

Desktop behaviour is working correctly.

Steps to reproduce (ensure you are viewing on a mobile size)

  1. Log in with a MetaMask wallet
  2. Open the side panel and select 'create agreement'
  3. Complete the required inputs
  4. Select the 'Save draft'
  5. Close the side panel via the top left 'X' icon
  6. The cancel action confirmation modal will show
  7. Navigate the agreements page. The draft agreement should show (ensuring the save is happening).

Step to be removed from the flow only for this action:

image

Expected behaviour

Actual behaviour

melyndav commented 2 days ago

@rdig can this be picked up?

rdig commented 2 days ago

Of course, just that realistically it won't get picked up until the end of cycle, or early next one

melyndav commented 2 days ago

All good, just wanted to flag it down. Thanks for adding it to cycle planning 👍 @rdig