Here's my PR to add filtering to the dashboard team chart legends. I took a little bit of liberty and interpreted the issue freely.
Now:
Legend entries that have a searchParam field will become buttons and set the searchParam if clicked
Legend entries that don't have that, stay a div
Like this the legend entry will not link to anything if it shouldn't (like usernames) and can still be quite general. I simplified the types a tiny bit (hope that's ok).
Testing
We are testing the Influence by team chart:
Step 1. Start the CDapp with data loaded
Step 2. Check the team chart and click a team
Individual teams should set the search param in the browser to their domain id. A click of 'All other' will not do that.
Description
Here's my PR to add filtering to the dashboard team chart legends. I took a little bit of liberty and interpreted the issue freely.
Now:
searchParam
field will become buttons and set thesearchParam
if clickeddiv
Like this the legend entry will not link to anything if it shouldn't (like usernames) and can still be quite general. I simplified the types a tiny bit (hope that's ok).
Testing
We are testing the Influence by team chart:
Individual teams should set the search param in the browser to their domain id. A click of 'All other' will not do that.
Diffs
New stuff ✨
Changes 🏗
Resolves #3147