JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[Dashboard] Total and payments values don't update after an ADVANCED_PAYMENT action is completed #3195

Closed mmioana closed 1 month ago

mmioana commented 1 month ago

The funds cards and total in and out widget should automatically update when an ADVANCED_PAYMENT action is completed, or a fund is claimed.

Currently this functionality exists for SIMPLE_PAYMENT when a simple payment transaction is completed, the necessary cache is cleared to force an automatic update of the values. (Ignore the incorrect value changes, they are fixed by another PR - more importantly, the value does change on a complete transaction)

https://github.com/user-attachments/assets/d40c5e5b-0e5e-4d28-8dcc-ac604d59eb9b

The same should happen when an ADVANCED_PAYMENT action is completed. This might be tricker as there are multiple stages to an advanced payment, and the claim delays affect when a payment is made / claimable. For payment rows with a claim delay of 0 the payment is automatically made when the release transaction is made. For any other claim delays, the required amount of time must pass before the payment can be claimed, so claiming a payment should also clear the cache.

(Video of how advanced payment release stage is currently working)

https://github.com/user-attachments/assets/0334a896-05d7-42cb-900d-a07485dfd23f

Suggestions

Check what caches are currently cleared by a simple payment action, apply the same cache clears to the advanced payments release stage and claim.