JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

Unable to reveal motion oppose vote #3258

Closed jakubcolony closed 1 month ago

jakubcolony commented 1 month ago

This issue is reproducible on master and in production.

Steps to reproduce

  1. Create a motion
  2. Stake it on both sides.
  3. Vote oppose.

Expected behaviour

Reveal step shows your oppose vote and you are able to reveal it.

Actual behaviour

You are presented with the following message:

No reveal required: You did not vote so do not need to reveal. Please wait for all required voters to reveal or the reveal stage to end.

Screen recording of the issue:

https://github.com/user-attachments/assets/98c65d26-26d5-40a1-a5b0-82069e9ebbe1

For reference, this is a recording from a different PR that shows the correct behaviour when voting oppose:

https://github.com/user-attachments/assets/74f8d7b7-a651-4018-8b98-b9c49b6d9b2c

jakubcolony commented 1 month ago

There's a good chance it was this change from #3108 that caused oppose votes not to show: https://github.com/JoinColony/colonyCDapp/pull/3108/files#diff-9d7ecddae6f660979fd92c6e5b45e48e4f75ec9d32c3326c606abc62f6b5c0edR120