Loading spinner on action timeline for Adv. payments

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer

5 stars 15 forks source link

Loading spinner on action timeline for Adv. payments #3299

Open arrenv opened 5 days ago

arrenv commented 5 days ago

Teamwork task: Loading spinner on action timeline for Adv. payments

Steps to reproduce

Create an Advanced payment action.
Note, the loading spinner in the right hand side action timeline.

Expected behaviour

The skeleton loader should remain until the content loads as opposed to both the skeleton and the loading spinner.

Actual behaviour

The loading spinner appears in the action timeline, which should be timeline.
You see both the skeleton loader and loading spinner on motions.

loading-wheel.webm

jakubcolony commented 3 days ago

Hey @arrenv, the screen recording shows a simple payment motion so could this be a motion-specific issue and not advanced payments? I think I'm seeing the correct behaviour on QA:

adv-payment-loading

arrenv commented 2 days ago

@jakubcolony I knew there was something funky there, when verifying, I seemed to only be able to replicate it on Adv. payments, but I seemingly ignored my own recording.

It seems fairly inconsistent, I just went and tested it again and am now getting it in the content area.

It seems unrelated to this PR, so, I will raise with Pagepro.

adam-strzelec commented 1 day ago

@arrenv @jakubcolony I noticed that the problem occurs when you create action with reputation method. This might not be so easy to fix, since the content on the right only starts loading once the content inside ActionSidebar has been rendered. I'll have to think about how to fix that.