JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

Pagination is broken on the Manage Tokens action #3404

Open iamsamgibbs opened 1 week ago

iamsamgibbs commented 1 week ago

Steps to reproduce

This bug is on both the action form and completed action.

Expected behaviour

The pagination components should appear and items 11 onwards should appear on page 2 onwards.

(Or this table should not use pagination, in which case the pagination components should be hidden - thoughts @arrenv ?)

The table should have a maximum row limit of 400 and never show the pagination components.

Actual behaviour

Items continue to be added to the current page and the pagination items do nothing.

https://github.com/user-attachments/assets/c37c7afa-d904-41a1-bfd1-6c43113d6a7d

arrenv commented 1 week ago

@iamsamgibbs Nice pick up! There should be no pagination at all, it should just be a long list, we could just arbitrarily or based on gas cost be consistent with Advanced payments and have a max table size of 400.

iamsamgibbs commented 1 week ago

This is also affecting the Manage Verified Members table:

Screenshot 2024-10-24 at 12 34 01

(Which has been raised as a point on #3164 so if it is fixed here first, make a note on that issue, or if it is fixed there first and for some reason doesn't also fix it here, should be able to copy across the same fix.)

Also worth checking the other tables on other actions to confirm this isn't happening anywhere else.