JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

No "Change action" confirmation modal when switching away from Advanced / Staged / Split payments #3466

Open iamsamgibbs opened 3 hours ago

iamsamgibbs commented 3 hours ago

Steps to reproduce

  1. Create an advanced / staged / split payment and fill out some of the fields
  2. Change to a different action type

Expected behaviour

Actual behaviour

Note the intended behaviour at the end of the video when switching away from Simple payment: https://github.com/user-attachments/assets/ca7d5db3-3ef8-48bf-9e46-24eaa51e5e74

Suggestions (optional)

This is possibly due to the way validation is done on these actions as it is done on submit rather than on change, but this is just a hunch. If this is the case then it may be a fiddly issue to resolve.

iamsamgibbs commented 3 hours ago

Hmm actually I can't recreate this again now (even though there is video proof in the issue of it not working). Whoever picks this up, check it is actually broken on master first.