JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

QA Dashboard: Follower count on dashboard doesn't match followers tab data and load in very slowly #3515

Open melyndav opened 2 weeks ago

melyndav commented 2 weeks ago

Issues

1. The number of followers shown on the dashboard, doesn't match the actual followers shown on the followers tab of the Members page.

Here you see the dashboard data:

image

Here you see the data on the followers tab count:

image

Another example from a different colony:

image

With the actual data being showed on the followers tab of the Members page:

image

Steps to reproduce

  1. View the followers and members count on a dashboard.
  2. Navigate to the Members page and check the count being displayed on the tabbed menu component.
  3. The followers data doesn't match the dashboard data.

2. When visiting a Colony with a large follower base, the followers on the dashboard load slowly and incrementally. With larger colonies with bigger follower bases, this isn't an ideal experience since it takes 18 seconds from skeleton load to load in 1500 members (the final follower total).

Export-1730206303289

Steps to reproduce

  1. Navigate to a colony with a large follower base. For this test, I use @rdig RC Colony which has 1500 followers.
  2. Load the colony and watch after the skeleton loader, the follower count in the top right header load in very slowly.

Expected behaviour

Actual behaviour


@iamsamgibbs here - Adding an extra issue to this as it overlaps!

The followers page should not have the team switcher.

The difference between a member and a follower is: a member is someone with reputation or permissions, while a follower is someone who joined the colony.

Individual teams do not have followers, only the colony as a whole, so we should remove the team switcher here. The same height should be maintained so that the "Members" / "Followers" tabs do not jump up and down when switching tabs.

The follower count should match the follower count on the dashboard and not filter by team even if ?team=3 is manually added to the URL.

image

rdig commented 2 weeks ago

For whoever picks this up, the "slow load" is a wiring mistake, it should use the count, rather then the actual data

However, for whom wishes to peek behind the curtain, that's how the member data actually loads, in batches of 100

iamsamgibbs commented 1 week ago

I've added an extra issue to the bottom of the original description as it overlaps a fair bit. I've increased the estimate by 4 hours to accommodate this.