JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
6 stars 15 forks source link

[Notifications - QA] Notifications not sent for Multi-Sig actions #3604

Closed olgapod closed 11 hours ago

olgapod commented 1 month ago

Steps to reproduce

  1. Log in as Leela in one browser, and Amy in another incognito browser. As Leela, install the multisig extension. Set the threshold to be fixed at "2".
  2. Give Leela and Amy multisig owner permissions. Check that you receive notifications for these.
  3. Create a multisig action. It can be any type of action as long as it is multisig. Check that you receive a notification when this is created.
  4. As Amy, add a second approval to the multi sig action. Go back to Leela and check that she received a new notification for the approval. Then finalize the motion as Leela, and check that she also received a notification for that.
  5. As Leela, make another multisig motion. Immediately go back to the approval step in the sidebar and remove her approval, then reject the motion. Check that a notification arrived for this rejection.

Steps in the task https://github.com/JoinColony/colonyCDapp/pull/3280

Expected behaviour

Actual behaviour

davecreaser commented 1 week ago

Hey @olgapod, also struggling to replicate this one, could you please check?

I tried a couple of times but the finalized notification always comes through. Thanks!

Screenshot 2024-11-28 at 15 28 13 Screenshot 2024-11-28 at 15 28 48
olgapod commented 11 hours ago

@davecreaser You are right, I also get all notifications now