JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

Production: Broken alignment in completed state of actions #3631

Open melyndav opened 1 week ago

melyndav commented 1 week ago

Description

In production, when an action is in the completed state, the avatars of members, tokens & colony logos are no longer aligned correctly. However, during the creation state, the avatars are aligned to the design correctly.

For the simple payment example below, the impacted fields are: Recipient and Amount.

image

A closer comparison (left side completed actions state, right side Figma)

image

Steps to reproduce

  1. Create a new action in production, ensuring it has a field where a circle avatar is used. Edit Colony details, any Payment type, Mint tokens etc.
  2. After completing the fields, take a screenshot before submitting the CTA.
  3. Select the CTA, and sign the transaction to complete the action.
  4. Take another screenshot of the completed state.
  5. Compare the location and positioning of the user/ token/ colony avatar.

Expected behaviour

The completed state should keep the same UI placement for all elements, including any avatars, and align with

Actual behaviour

The UI and positioning of elements within the action change from the created to the completed state.