JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[Payment - QA]The "Create Payment" button should be disabled if user don't have enough funds #3650

Closed olgapod closed 1 week ago

olgapod commented 1 week ago

Steps to reproduce

  1. Enable "Staking Advanced Payments" extension.
  2. User with not enough funds Create a split payment.
  3. Open "Create a payment" step.
  4. Press "Create payment" button.
  5. Observe that the "Create Payment" button remains clickable.

Expected behaviour

Actual behaviour

image
melyndav commented 1 week ago

Hey @olgapod, can you update the image for this issue to the correct one? This screenshot is showing with the 'leave this colony' example and doesn't correlate to the payment behaviour.

olgapod commented 1 week ago

@melyndav Thank you for this notice, I changed an issue

melyndav commented 1 week ago

Thanks for updating the screenshot @olgapod. We don't disable buttons (globally where possible) to allow the user to get feedback as to why they can't perform an action, and in this case, why they can't create a payment.

The user can exit by 'cancelling' or closing the modal via the 'X'.

As a potential improvement here, we could show this error upon selection of the 'Staking' decision method so they do not spend time completing the rest of the payment.

I will log this as a UX improvement in the design kanban, but this issue can be closed.

olgapod commented 1 week ago

@melyndav thanks, close it