QA Notifications: Notifications tab UI fixes - Githubissues

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer

5 stars 14 forks source link

QA Notifications: Notifications tab UI fixes #3667

Open melyndav opened 2 weeks ago

melyndav commented 2 weeks ago

Description

All issues raised impact all responsive sizing.

Issue 1: The new notifications tab in the userhub is missing HR's between each notification item as per the design and other userhub tabs.

Currently, in QA:

Figma design:

Figma

Link to Figma design - https://www.figma.com/design/0Fi3AaDlr3LAXBfsOXBGyk/User-Account?node-id=6754-9622&t=QSsB9RdPVTORnWg3-4

Lin to design system component: https://www.figma.com/design/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?node-id=1782-51509&m=dev

Issue 2: The 'Mark all as read text' is missing a hover state. Please add a gray-900 to this text when hovered on desktop.

Issue 3: The padding between the notification heading and first item and in-between each item including the missing HR rule should match Figma.

Link component to correct issues: https://www.figma.com/design/l1dOM5qiQYwF0ElvKDqqjg/Design-System---Colony-v3?node-id=1782-51509&t=NHTBNFxfk12vDSQh-4

melyndav commented 2 weeks ago

FYI: @rdig merged #3519 into this one. Thanks for the nudge.