search

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

bug: you can't create a motion to transfer funds from a subdomain to the parent domain #3704

Open bassgeta opened 5 days ago

bassgeta commented 5 days ago

Steps to reproduce

  1. Install and enable the voting reputation extension
  2. Try to create a Transfer funds action moving some CREDS from Andromeda to General image
  3. The transaction estimation fails with reason voting-rep-invalid-domain-id

Suggestions (optional)

This happens because our moveFunds action creation doesn't set the third parameter correctly. We should have an action domain which we check permissions for, and then use that. Instead it always uses the fromDomain, but the "action domain" depends on where are we moving funds from and to. image

While you're at it, change the third parameter of the multisig motion call too, to use the correct "action domain" instead.