JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

[Expenditures] bug: all of voting reputation motions to fund an expenditure use the root domain to check for permissions #3705

Open bassgeta opened 5 days ago

bassgeta commented 5 days ago

This is something I have discovered while rummaging around the codebase, but given these few lines image

Makes it apparent that we always check for permissions in the root domain. Why does this work? Well because we have another bug that always creates an expenditure in the root domain, so this works by chance :melting_face:

How to solve it

We need to create expenditures in the domain we are funding it from and then we need to realign the funding motion to get the action domain and get all the skill indices accordingly.

TBD: needs more info, if something is amiss, just ping @bassgeta