This PR reimplements the fund expenditure via voting reputation saga so it uses the new helpers and it adds support for changing the funding motion created in domain.
Testing
Install the voting reputation extension
Create an advanced payment as leela sending some funds to some recipients from General
Get to the funding step and fund it via Reputation
Fully support the motion, run npm run forward-time 1 and try to finalize it. Then release it and verify that the funds were sent (leela had 396 at start, now she has 398 so hooray!)
ALright so funding from general works which is all fine, now let's check out 2 more cases
Create an advanced payment as leela sending some funds to some recipients from Andromeda
Get to the funding phase and choose Reputation as the decision method
Fully support it, run npm run forward-time 1 and refresh the page. Finalize the motion, release the payment and verify that the changes are applied (for example check if Andromeda's funds were drained).
Now open the FundingModal file and change line 270
to motionDomainId: selectedTeam.nativeId,
Create an advanced payment as leela sending some funds to some recipients from Andromeda
Get to the funding step and choose Reputation as the decision method.
Verify that the motion gets created (we can't really check that it's been created in Andromeda in the UI) in Andromeda, by running this query
Description
This PR reimplements the fund expenditure via voting reputation saga so it uses the new helpers and it adds support for changing the funding motion created in domain.
Testing
leela
sending some funds to some recipients fromGeneral
npm run forward-time 1
and try to finalize it. Then release it and verify that the funds were sent (leela
had 396 at start, now she has 398 so hooray!)ALright so funding from general works which is all fine, now let's check out 2 more cases
leela
sending some funds to some recipients fromAndromeda
Reputation
as the decision methodnpm run forward-time 1
and refresh the page. Finalize the motion, release the payment and verify that the changes are applied (for example check if Andromeda's funds were drained).Now open the
FundingModal
file and change line 270 tomotionDomainId: selectedTeam.nativeId,
leela
sending some funds to some recipients fromAndromeda
Reputation
as the decision method.Andromeda
in the UI) in Andromeda, by running this queryand verify that the
nativeMotionDomainId
is 2 (ignore the blue blocks, it was testing time :D )npm run forward-time 1
and finalize it then release the payment. Verify that the funds were moved.As an additional sanity check, install the multisig extension, set the threshold to 1, create an advanced payment and fund it via multisig.
Diffs
Changes 🏗
fundExpenditureMotion
now uses the new helpers and supports creating the motion in a different domain than rootResolves #3705