JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer
5 stars 14 forks source link

Fix: Username field should show correct count #3731

Closed iamsamgibbs closed 3 days ago

iamsamgibbs commented 4 days ago

Description

This PR fixes an issue on the username field on the profile page which would always show 0/30. I made a decision to hide the counter all together when the field is disabled as this seems more logical to me - I can easily add this back in if preferred.

Testing

Step 1 - Navigate to http://localhost:9091/account/profile and ensure the max character limit does not display.

Screenshot 2024-11-18 at 15 56 04

Step 2 - Open src/components/frame/v5/pages/UserProfilePage/partials/UserAccountForm/hooks.tsx and change line 131 to shouldNumberOfCharsBeVisible: true, and line 134 to isDisabled: false,. Confirm the character count is visible and updates correctly.

Screenshot 2024-11-18 at 15 57 09

Diffs

Changes 🏗

Resolves #3472