Fix: Update username validation message - Githubissues

JoinColony / colonyCDapp

An iteration of the Colony Dapp sporting both a fully decentralized operating mode, as well as a mode enhanced by a metadata caching layer

5 stars 14 forks source link

Fix: Update username validation message #3752

Open iamsamgibbs opened 4 days ago

iamsamgibbs commented 4 days ago

Description

The previous username validation message was too vague, this PR updates the validation to be more descriptive and adds a minimum character count.

Testing

Step 1 - Connect to a wallet (Dev wallet 4 onwards) without a profile and create a new profile. Enter a username with either fewer than 3 characters, more than 30, or includes special characters.

Screenshot 2024-11-22 at 08 38 11

Step 2 - Either finish creating a profile, or connect to a wallet with a profile already created.
Step 3 - Go to the manage profile page.
Step 4 - Open: src/components/frame/v5/pages/UserProfilePage/partials/UserAccountPage/hooks.tsx and change line 92 to canChangeUsername: true, - the username field should now be editable.
Step 5 - Check the same validation applies and the same messages appear.

Screenshot 2024-11-22 at 14 53 44

Diffs

Changes 🏗

Updated username validation message
Added minimum character count validation

Resolves #3312

iamsamgibbs commented 3 days ago

Good suggestion @bassgeta I've made some changes to unify this and added an extra testing step.