search

JoinColony / colonyDapp

Colony dApp client
49 stars 19 forks source link

🔥 Can't burn tokens at 0x0 🔥 #1911

Open auryn-macmillan opened 4 years ago

auryn-macmillan commented 4 years ago

Steps to reproduce

  1. Assign a task to 0x0000000000000000000000000000000000000000)
  2. Try to finalize it.

Expected behaviour

🔥🔥🔥 (the funds should be sent to 0x0000000000000000000000000000000000000000)

Actual behaviour

image

auryn-macmillan commented 4 years ago

assigning rolls to 0x0

This is perhaps a breadcrumb. Assigning a roll to 0x0 has some weird behaviour. The permission shows up in the dapp, but no transaction happens.

image

kronosapiens commented 4 years ago

@auryn-macmillan can you explain why this functionality is necessary? As part of https://github.com/JoinColony/colonyNetwork/pull/693 we are going to have a recipient of 0x0 result in funds being returned to the domain, which conflicts with this functionality. Can you give a legitimate use-case for this? It seems more likely that recipients would be set to 0x0 by accident.

Update: never mind, I chatted with Alex and we're going to go ahead and allow this. Generality trumps convenience this time around.

rdig commented 2 years ago

This still seems to be case: Screenshot from 2021-10-24 16-41-25

@area is this issue still relevant? Meaning do we want to keep this issue open as perhaps one day we'll implement this, or can I close it ?